fix: show OpenAI profile add alert #48

Merged

wmc merged 1 commit from codex/profile-plus-alert into main 2026-06-23 12:47:13 +00:00

Conversation 0 Commits 1 Files changed 5 +119 -36

wmc commented 2026-06-23 12:47:07 +00:00

Owner

Copy link

Summary:

• consolidate ContentView warnings behind one ContentAlert/.alert(item:) presenter
• route the OpenAI profile/account plus action through that shared presenter so the login warning is not shadowed by footer alerts
• update README and TODO with the menu-bar behavior

Verification:

• RED: ContentAlertTests initially failed to build with Cannot find 'ContentAlert' in scope
• DEVELOPER_DIR=/Applications/Xcode-beta.app/Contents/Developer xcodebuild test -project CodexModelSwitcher.xcodeproj -scheme CodexModelSwitcher -destination platform=macOS -derivedDataPath /tmp/CodexModelSwitcher-DerivedData-profile-alert CODE_SIGNING_ALLOWED=NO -only-testing:CodexModelSwitcherTests/ContentAlertTests
• DEVELOPER_DIR=/Applications/Xcode-beta.app/Contents/Developer scripts/verify.sh
• git diff --check
• DEVELOPER_DIR=/Applications/Xcode-beta.app/Contents/Developer xcodebuild build -project CodexModelSwitcher.xcodeproj -scheme CodexModelSwitcher -configuration Release -destination platform=macOS -derivedDataPath /tmp/CodexModelSwitcher-DerivedData-app CODE_SIGNING_ALLOWED=NO
• runtime smoke: restarted the Release app from /tmp/CodexModelSwitcher-DerivedData-app/Build/Products/Release/CodexModelSwitcher.app; pgrep -x CodexModelSwitcher showed one running process

Review:

• subagent review returned Ready with no Critical/Important/Minor findings

Summary: - consolidate ContentView warnings behind one ContentAlert/.alert(item:) presenter - route the OpenAI profile/account plus action through that shared presenter so the login warning is not shadowed by footer alerts - update README and TODO with the menu-bar behavior Verification: - RED: ContentAlertTests initially failed to build with `Cannot find 'ContentAlert' in scope` - `DEVELOPER_DIR=/Applications/Xcode-beta.app/Contents/Developer xcodebuild test -project CodexModelSwitcher.xcodeproj -scheme CodexModelSwitcher -destination platform=macOS -derivedDataPath /tmp/CodexModelSwitcher-DerivedData-profile-alert CODE_SIGNING_ALLOWED=NO -only-testing:CodexModelSwitcherTests/ContentAlertTests` - `DEVELOPER_DIR=/Applications/Xcode-beta.app/Contents/Developer scripts/verify.sh` - `git diff --check` - `DEVELOPER_DIR=/Applications/Xcode-beta.app/Contents/Developer xcodebuild build -project CodexModelSwitcher.xcodeproj -scheme CodexModelSwitcher -configuration Release -destination platform=macOS -derivedDataPath /tmp/CodexModelSwitcher-DerivedData-app CODE_SIGNING_ALLOWED=NO` - runtime smoke: restarted the Release app from `/tmp/CodexModelSwitcher-DerivedData-app/Build/Products/Release/CodexModelSwitcher.app`; `pgrep -x CodexModelSwitcher` showed one running process Review: - subagent review returned Ready with no Critical/Important/Minor findings

wmc added 1 commit 2026-06-23 12:47:07 +00:00

fix: show OpenAI profile add alert 9a4b3d546c

wmc merged commit 74f1e55157 into main 2026-06-23 12:47:13 +00:00

wmc referenced this pull request from a commit 2026-06-23 12:47:13 +00:00

Merge pull request 'fix: show OpenAI profile add alert' (#48) from codex/profile-plus-alert into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

wmc/CodexModelSwitcher!48

No description provided.